RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

forax at univ-mlv.fr forax at univ-mlv.fr
Fri Aug 24 10:05:48 UTC 2018



----- Mail original -----
> De: "Claes Redestad" <claes.redestad at oracle.com>
> À: "Remi Forax" <forax at univ-mlv.fr>
> Cc: "core-libs-dev" <core-libs-dev at openjdk.java.net>
> Envoyé: Vendredi 24 Août 2018 11:38:35
> Objet: Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

> Hi,
> 
> On 2018-08-23 17:12, Remi Forax wrote:
>> Hi Claes,
>>
>>    useCanonPrefixCache = useCanonCaches ?
>>    getBooleanProperty("sun.io.useCanonPrefixCache",false) : false;
>> can be written
>>    useCanonPrefixCache = useCanonCaches &&
>>    getBooleanProperty("sun.io.useCanonPrefixCache",false);
> 
> sure.
>> and the name useCanonCaches/useCanonPrefixCache should follow the coding
>> convention USE_CANON_CACHES/USE_CANON_PREFIX_CACHE.
> 
> While agreeable, I think there's also value that the constants reflect
> the property names used to set them, while renaming the properties feels
> far out of scope. I'll opt not to rename anything, unless you insist.

i will not insist,
so looks good to me !

> 
> /Claes

Rémi


More information about the core-libs-dev mailing list