[12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

[Brian Burkhalter]

This one could still use a Reviewer approval or rejection.

Thanks,

Brian

On Aug 14, 2018, at 1:34 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> Hi Bernard,
> 
> On Aug 14, 2018, at 4:13 AM, B. Blaser <bsrbnd at gmail.com> wrote:
> 
>> Seems quite good to me, last notes:
>> 
>> 1) dealing with 'stat/stat64' in 'UnixFileSystem_md.c' might be
>> outside the scope of this fix (?) even if fully pertinent per [1].
> 
> It might be slightly out of scope but I think it’s OK as stat64 was defined inside an
> #if defined(_ALLBSD_SOURCE) conditional compilation block.
> 
>> In the same file, I think '#define dirent dirent64' is probably missing
>> for AIX.
> 
> Fixed.
> 
>> 2) I guess '#if defined(_AIX) ...' is now missing in 'OperatingSystemImpl.c':
>> #if defined(_AIX)
>>  #define DIR DIR64
>>  #define dirent dirent64
>>  #define opendir opendir64
>>  #define readdir readdir64
>>  #define closedir closedir64
>> #endif
> 
> Fixed.
> 
> Webrev updated in place: http://cr.openjdk.java.net/~bpb/8207744/webrev.04/.
> 
> Checks out on Linux-x64, macOS, Solaris-sparcv9, Windows-x64.
> 
>> You'll probably need some more reviews especially for other systems
>> than Linux 64-bit.
> 
> It would not hurt. In any case I do not yet have a Reviewer approval.
> 
> Thanks,
> 
> Brian