RFR: JDK-8210031: implementation for JVM Constants API

[Vicente Romero]

Hi all,

Can I have the final nod to the JVM constants API, there have been some 
changes since the last review iteration. Thanks to the internal and 
external developers that have taken the time to provide feedback so far. 
The links to the last versions are:

webrev: http://cr.openjdk.java.net/~vromero/8210031/webrev.10/
javadoc: 
http://cr.openjdk.java.net/~vromero/8210031/javadoc.18/overview-summary.html
specdiff: 
http://cr.openjdk.java.net/~vromero/8210031/specdiff.08/overview-summary.html

Thanks,
Vicente


On 10/18/18 9:55 PM, Mandy Chung wrote:
>
>
> On 10/15/18 11:12 AM, Vicente Romero wrote:
>>
>> [1] http://cr.openjdk.java.net/~vromero/8210031/webrev.01
>
> I reviewed java.lang.invoke change in details.  I have skimmed through 
> the new classes.
> I will look at the new tests next.
>
> @since 12 is missing in the new APIs
>
> VarHandle.java
> 1887 public final String toString() {
> 1888 // @@@ defer to concrete type for additional description
> 1889 // see https://bugs.openjdk.java.net/browse/JDK-8199149 You may 
> want to take out this comment or L1889 as we can refer back to 
> JDK-8199149. VarHandles.java
>  169         // @@@ This is a little fragile assuming the base is the 
> class
>
> Maybe FieldStaticReadOnly and FieldStaticReadWrite constructor and
> getStaticFieldFromBaseAndOffset method should take Class<?> refc
> rather than Object base. FieldStaticReadXXX will do the cast when
> calling getStaticFieldFromBaseAndOffset.
>
> java.base module-info.java
>    It'd be good to keep the exported APIs in alphabetical order.
>
> java/lang/invoke/TypeDescriptor.java
>    copyright header is missing
>
> Mandy