RFR 8171426 : java/lang/ProcessBuilder/Basic.java failed with Stream closed

James Laskey james.laskey at oracle.com
Tue Dec 4 17:18:16 UTC 2018


I wasn’t as fussy about the original comment but this one is also fine. 

Sent from my iPhone

> On Dec 4, 2018, at 12:58 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> 
> Hi Brian, Jim,
> 
> Thanks for the reviews.
> 
> I simplify the description, the full details are in the bug report
> and are more complete.
> 
> Updated webrev:
>   http://cr.openjdk.java.net/~rriggs/webrev-basic-8171426-1/
> 
> Thanks, Roger
> 
> 
>> On 12/03/2018 04:49 PM, Brian Burkhalter wrote:
>> Hi Roger,
>> 
>> L2:copyright year, of course
>> L2119: The verbiage seems a little obtuse.
>> 
>> Otherwise, +1.
>> 
>> Thanks,
>> 
>> Brian
>> 
>>> On 11/27/2018 02:04 PM, Roger Riggs wrote:
>>> Please review a test update to address an intermittent test failure.
>>> The test is modified to accept the current implementation behavior of the input streams
>>> from processes that may under race conditions with close throw IOE("Stream closed").
>>> 
>>> Details and analysis in the Jira:
>>> https://bugs.openjdk.java.net/browse/JDK-8171426
>>> 
>>> Webrev:
>>> http://cr.openjdk.java.net/~rriggs/webrev-basic-8171426/ <http://cr.openjdk.java.net/%7Erriggs/webrev-basic-8171426/>
>>> 
>>> Thanks, Roger
>> 
> 



More information about the core-libs-dev mailing list