JDK-8211844 [aix] ProcessBuilder: Piping between created processes does not work.
Roger Riggs
Roger.Riggs at oracle.com
Mon Dec 10 17:29:47 UTC 2018
Hi,
The change looks fine and passes the current tests.
So ok to push.
I think the test isn't correct, but I have not yet worked up a revised test.
Thanks, Roger
On 12/10/2018 09:00 AM, Lindenmaier, Goetz wrote:
> Hi Steve,
>
> I will push it once Roger gives his ok.
>
> Best regards,
> Goetz.
>
>> -----Original Message-----
>> From: Steve Groeger <GROEGES at uk.ibm.com>
>> Sent: Montag, 10. Dezember 2018 14:42
>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
>> Cc: core-libs-dev at openjdk.java.net; Roger Riggs <Roger.Riggs at oracle.com>
>> Subject: RE: JDK-8211844 [aix] ProcessBuilder: Piping between created
>> processes does not work.
>>
>> Hi Goetz,
>>
>> It is good that the tests you ran passed. What needs to be done now to get
>> this change pushed into the main code?
>>
>> Thanks
>> Steve Groeger
>> IBM Runtime Technologies
>> Hursley, Winchester
>> Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129
>> Fax (44) 1962 816800
>> Lotus Notes: Steve Groeger/UK/IBM
>> Internet: groeges at uk.ibm.com
>>
>> Unless stated otherwise above:
>> IBM United Kingdom Limited - Registered in England and Wales with number
>> 741598.
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
>> 3AU
>>
>>
>>
>> From: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>
>> To: Steve Groeger <GROEGES at uk.ibm.com>, Roger Riggs
>> <Roger.Riggs at oracle.com>
>> Cc: "core-libs-dev at openjdk.java.net" <core-libs-dev at openjdk.java.net>
>> Date: 10/12/2018 10:06
>> Subject: RE: JDK-8211844 [aix] ProcessBuilder: Piping between created
>> processes does not work.
>>
>> ________________________________
>>
>>
>>
>>
>> Hi,
>>
>> I ran the fix through our tests. There are no new regressions, and the
>> addressed test works.
>>
>> So reviewed from my side.
>>
>> I increased the bug to P3 so we can push it to jdk12 in case we
>> miss Thursday.
>>
>> Best regards,
>> Goetz.
>>
>>> -----Original Message-----
>>> From: core-libs-dev <core-libs-dev-bounces at openjdk.java.net> On Behalf
>> Of
>>> Steve Groeger
>>> Sent: Freitag, 7. Dezember 2018 19:08
>>> To: Roger Riggs <Roger.Riggs at oracle.com>
>>> Cc: core-libs-dev at openjdk.java.net
>>> Subject: Re: JDK-8211844 [aix] ProcessBuilder: Piping between created
>>> processes does not work.
>>>
>>> Hi Roger,
>>>
>>> I have made the same change to the Solaris code and also removed the test
>>> from the ProblemList.txt
>>> I have created a webrev here:
>>> http://cr.openjdk.java.net/~sgroeger/jtreg/8211844/webrev.01/
>> <http://cr.openjdk.java.net/~sgroeger/jtreg/8211844/webrev.01/>
>>> Hope you can now test t
>>>
>>> Thanks
>>> Steve Groeger
>>> IBM Runtime Technologies
>>> Hursley, Winchester
>>> Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129
>>> Fax (44) 1962 816800
>>> Lotus Notes: Steve Groeger/UK/IBM
>>> Internet: groeges at uk.ibm.com
>>>
>>> Unless stated otherwise above:
>>> IBM United Kingdom Limited - Registered in England and Wales with
>> number
>>> 741598.
>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
>>> 3AU
>>>
>>>
>>>
>>> From: Roger Riggs <Roger.Riggs at oracle.com>
>>> To: core-libs-dev at openjdk.java.net
>>> Date: 07/12/2018 14:55
>>> Subject: Re: JDK-8211844 [aix] ProcessBuilder: Piping between
>>> created processes does not work.
>>> Sent by: "core-libs-dev" <core-libs-dev-bounces at openjdk.java.net>
>>>
>>>
>>>
>>> Hi,
>>>
>>> I notice that the Solaris case also does not include "||
>>> forceNullOutputStream".
>>> I'll have to investigate why the Pipeline test didn't fail on Solaris.
>>>
>>> Please add that to the patch and I'll run it through our tests.
>>>
>>> Thanks, Roger
>>>
>>> On 12/07/2018 03:05 AM, Volker Simonis wrote:
>>>> Hi Steve,
>>>>
>>>> thanks a lot for this fix. I'm forwarding this to core-libs-dev as
>>>> well, because that's where the review has to take place. The
>>>> "ppc-aix-port-dev" list is mostly a marker for the port maintainers to
>>>> get their attention on relevant changes (so cross-posting is fine in
>>>> this case :)
>>>>
>>>> On Thu, Dec 6, 2018 at 4:26 PM Steve Groeger <GROEGES at uk.ibm.com>
>>> wrote:
>>>>> Hi all,
>>>>>
>>>>> I have been investigating the issue
>>> https://bugs.openjdk.java.net/browse/JDK-8211844
>> <https://bugs.openjdk.java.net/browse/JDK-8211844>
>>> raised by Goetz Lindenmaier which is related to the
>>>>> jdk/java/lang/ProcessBuilder/PipelineTest.java JTReg test failing on
>>> AIX. Having done some investigation I have a potential fix fore the issue:
>>>>>
>>>>> diff -r 9501a7b59111
>>> src/java.base/unix/classes/java/lang/ProcessImpl.java
>>>>> --- a/src/java.base/unix/classes/java/lang/ProcessImpl.java Mon Dec
>>> 03 14:28:19 2018 +0300
>>>>> +++ b/src/java.base/unix/classes/java/lang/ProcessImpl.java Thu Dec
>>> 06 15:01:03 2018 +0000
>>>>> @@ -446,7 +446,7 @@
>>>>> ProcessBuilder.NullOutputStream.INSTANCE :
>>>>> new ProcessPipeOutputStream(fds[0]);
>>>>>
>>>>> - stdout = (fds[1] == -1) ?
>>>>> + stdout = (fds[1] == -1 || forceNullOutputStream) ?
>>>>> ProcessBuilder.NullInputStream.INSTANCE :
>>>>> new
>>> DeferredCloseProcessPipeInputStream(fds[1]);
>>>> Your change looks good and I can sponsor it. Just as a hint for other
>>>> reviewers I'd like to mention that this change, albeit in a shared
>>>> Java file, is still AIX-only because it is in the "AIX" case of a
>>>> switch statement.
>>>>
>>>> @Steve: can you please verify, that your change introduces no
>>>> regression by running the complete jtreg test suite.
>>>>
>>>> Thank you and best regards,
>>>> Volker
>>>>
>>>>> I would appreciate any feedback please, and for someone to be a
>> sponsor
>>> for this and to contributute it to OpenJDK.
>>>>> Steve Groeger
>>>>> IBM Runtime Technologies
>>>>> Hursley, Winchester
>>>>> Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129
>>>>> Fax (44) 1962 816800
>>>>> Lotus Notes: Steve Groeger/UK/IBM
>>>>> Internet: groeges at uk.ibm.com
>>>>>
>>>>> Unless stated otherwise above:
>>>>> IBM United Kingdom Limited - Registered in England and Wales with
>>> number 741598.
>>>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
>> PO6
>>> 3AU
>>>>> Unless stated otherwise above:
>>>>> IBM United Kingdom Limited - Registered in England and Wales with
>>> number 741598.
>>>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
>> PO6
>>> 3AU
>>>
>>>
>>>
>>>
>>>
>>> Unless stated otherwise above:
>>> IBM United Kingdom Limited - Registered in England and Wales with
>> number
>>> 741598.
>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
>>> 3AU
>>
>>
>>
>> Unless stated otherwise above:
>> IBM United Kingdom Limited - Registered in England and Wales with number
>> 741598.
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
>> 3AU
More information about the core-libs-dev
mailing list