RFR(XS): 8215009: GCC 8 compilation eror in libjli
Dmitry Chuyko
dmitry.chuyko at bell-sw.com
Tue Dec 11 11:30:07 UTC 2018
On 12/11/18 4:03 AM, David Holmes wrote:
> Hi Dmitry,
>
> On 11/12/2018 12:16 am, Dmitry Chuyko wrote:
>> Hello,
>>
>> Please review a small fix in java_md_solinux.c: continuation is not
>> truly compatible with pthread_create start_routine's signature but we
>> control what actually happens. So it makes sense to add intermediate
>> void* cast to silence the error.
>
> I'd be tempted to fix the signature and get rid of all the casts.
David, the signature is a signature of
int JNICALL JavaMain(void * _args)
It would be fun to change it. But still on Windows it is correctly
passed to _beginthreadex() and then return code is extracted with
GetExitCodeThread(). In case we want it to return void* the cast will
move there.
-Dmitry
>
> Cheers,
> David
>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8215009
>> webrev: http://cr.openjdk.java.net/~dchuyko/8215009/webrev.00/
>> testing: submit repo
>> (mach5-one-dchuyko-JDK-8215009-20181207-1625-13615: PASSED)
>>
>> -Dmitry
>>
More information about the core-libs-dev
mailing list