[12] RFR: 8215194: Initial size of UnicodeBlock map is incorrect

Roger Riggs Roger.Riggs at oracle.com
Tue Dec 11 15:57:23 UTC 2018


Hi Naoto,

Since the value changes from time to time, it would give it some visibility
if it were defined using a private final int  (or float)
      private final int MAP_CAPACITY = 667;

Though I suppose the test can't use the value without using reflection.
But it would lower the maintenance in the long term.

$.02, Roger

On 12/11/2018 09:51 AM, Naoto Sato wrote:
> Hi,
>
> Please review the fix for the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8215194
>
> The proposed fix is located at:
>
> http://cr.openjdk.java.net/~naoto/8215194/webrev.00/
>
> This one line fix is for the correctness of the initial map size of 
> Character.UnicodeBlock.
>
> Naoto



More information about the core-libs-dev mailing list