RFR: JDK-8066619: String(byte[],int,int,int) in String has been deprecated in Manifest and Attributes

[Lance Andersen]

Hi Roger,

Thank you.  I am OK with the current version of the patch.

Happy Holidays!

Best
Lance
> On Dec 20, 2018, at 10:50 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> 
> Hi Lance,
> 
> Webrev:
>   http://cr.openjdk.java.net/~rriggs/webrev-8066619-5.patch/
> 
> Phillip does not yet have access to cr.openjdk.java.net.
> 
> $.02, Roger
> 
> On 12/20/2018 09:17 AM, Lance Andersen wrote:
>> Hi Philipp,
>> 
>> The tests look better.  Any chance you can post the webrev in the future vs the patch as it makes it easer to review.
>> 
>> Best
>> Lance
>>> On Dec 19, 2018, at 1:24 AM, Philipp Kunz <philipp.kunz at paratix.ch> wrote:
>>> 
>>> now with assertThrows. Find a new patch attached.
>>> 
>>> On Tue, 2018-12-18 at 13:38 -0800, Martin Buchholz wrote:
>>>> On Tue, Dec 18, 2018 at 1:13 PM Lance Andersen <lance.andersen at oracle.com <mailto:lance.andersen at oracle.com>>
>>>> wrote:
>>>> 
>>>>> 
>>>>> 
>>>>> Is there a reason you did not use
>>>>> 
>>>>> @Test(expectedExceptions = IOException.class)
>>>>> 
>>>>> It just seems to make the test a bit more readable
>>>>> 
>>>>> That construct has lost popularity over the past decade, sort of like
>>>> inheritance is no longer considered a silver bullet.
>>> <8066619.patch>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> 
>> 
>> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>