RFR 8198645 Use System.lineSeparator() instead of getProperty("line.separator")

Lance Andersen lance.andersen at oracle.com
Fri Feb 23 20:37:28 UTC 2018


still looks good

> On Feb 23, 2018, at 3:33 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> 
> There are two more changes in the java.xml package. (Thanks Joe)
> Webrev updated in place.
> 
>   http://cr.openjdk.java.net/~rriggs/webrev-line-separator-8198645/
> 
> Thanks, Roger
> 
> On 2/23/2018 2:50 PM, Xueming Shen wrote:
>> +1
>> 
>> On 02/23/2018 11:39 AM, Roger Riggs wrote:
>>> Please review cleanup replacements of System.getProperty("line.separator") with System.lineSeparator().
>>> It uses the line separator from System instead of looking it up in the properties each time.
>>> Also fixed one javadoc @see reference.
>>> 
>>> The affected files are in several packages:
>>> 
>>>    com/sun/crypto/provider/
>>>    java/util/regex/
>>>    jdk/internal/util/xml/impl/
>>> 
>>> Webrev:
>>> http://cr.openjdk.java.net/~rriggs/webrev-line-separator-8198645/
>>> 
>>> Thanks, Roger
>>> 
>>> 
>> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list