[11] RFR: (JAXP) 8038043: Xerces Update: XInclude update

[Joe Wang]

Looks good. Thanks!

Best,
Joe

On 2/26/2018 7:34 AM, Aleks Efimov wrote:
> Hi Joe,
>
> Thank you for the review. I've updated XIncludeHandler and 
> XIncludeTextReader files per your suggestions.
> XIncludeTextReader:191 line is still shown in Sdiffs as one line, but 
> patch contains correct change that splits it.
>
> New webrev: http://cr.openjdk.java.net/~aefimov/8038043/11/01
>
> Best,
> Aleksei
>
>
> On 02/22/2018 08:39 AM, Joe Wang wrote:
>> Hi Aleksei,
>>
>> Thanks for taking the time to work on this!
>>
>> Looks good overall.
>>
>> XIncludeHandler: setupCurrentBaseURI method can be private.
>>
>> XIncludeTextReader: there's a very long line at 191. It would be good 
>> to fix it so that Sdiffs looks better the next time.
>>
>> As for the tests, I'm fine with the encoding tests plus passing all 
>> existing ones.
>>
>> Best,
>> Joe
>>
>> On 2/16/2018 9:53 AM, Aleks Efimov wrote:
>>> Hi,
>>>
>>> Please, help to review the update of XInclude related classes from 
>>> the Apache Xerces 2.11.0 source.
>>> JBS:
>>>     https://bugs.openjdk.java.net/browse/JDK-8038043
>>> The webrev:
>>>     http://cr.openjdk.java.net/~aefimov/8038043/11/00/
>>>
>>> New regression test has been added to check the updated reporting of 
>>> invalid bytes encountered during the parsing and inclusion of XML 
>>> documents. New test and other regression tests shows no failures.
>>>
>>> With Best Regards,
>>> Aleksei
>>
>