RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

[Volker Simonis]

Hi Goetz,

you change looks good. Just one minor nit (no need for a new webrev if
you agree with my fix :)

In BadPluginConfigurationTest.sh you first check if 'mktemp' exists as
file. This is a useless check because there won't be a file "mktemp"
in the current exectution directory of the shell script, even if the
"mktemp" exists domehwere in the PATH. To check for the existence of a
"mktemp" executable you can use the "type" command:

type mktempp> /dev/null 2>&1

if ! [ $? -ne 0 ] ; then
  MKTEMP="/opt/freeware/bin/mktemp"
fi

Thanks for finally fixing this,
Volker


On Mon, Jan 15, 2018 at 12:12 PM, Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
> Hi Matthias,
>
> I didin't mean to do any changes for other platforms, so
> I reverted the part you pointed out:
> http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev.02/
>
> But scanning through all the scripts:
> Sometimes PS on Cygwin is ';' and sometimes it is ':'.  Strange ...
>
> Best regards,
>   Goetz.
>
>> -----Original Message-----
>> From: Baesken, Matthias
>> Sent: Montag, 15. Januar 2018 09:03
>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; core-libs-
>> dev at openjdk.java.net
>> Subject: RE: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.
>>
>> Hi Goetz, change looks good except
>>
>> test/jdk/sun/security/tools/keytool/i18n.sh
>>
>> where the Cygwin PS setting has been changed from ; to :   (probably this
>> was not intended) :
>>
>>      PS=":"
>>      FS="/"
>>      ;;
>> -  CYGWIN* )
>> -    NULL=/dev/null
>> -    PS=";"
>>
>>
>> (not a Reviewer however).
>>
>> Best regards, Matthias
>>
>>
>>
>> > -----Original Message-----
>> > From: Lindenmaier, Goetz
>> > Sent: Mittwoch, 10. Januar 2018 09:23
>> > To: core-libs-dev at openjdk.java.net
>> > Cc: Baesken, Matthias <matthias.baesken at sap.com>
>> > Subject: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.
>> >
>> > Hi,
>> >
>> > this change adapts a row of jtreg tests to AIX.
>> > Shell tests often switch over all OSes, here the case for AIX was
>> > missing. PKCSTest needs to know where the libs are on s390.
>> >
>> > Please review.
>> > http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev/
>> >
>> > Best regards,
>> >   Goetz.