RFR(XS): 8195663: jdk/tools/launcher/HelpFlagsTest.java fails with java.lang.AssertionError: HelpFlagsTest failed:

[David Holmes]

Hi Goetz,

On 19/01/2018 2:24 AM, Lindenmaier, Goetz wrote:
> Posting this to core-libs-dev.
> 
> Please review
> http://cr.openjdk.java.net/~goetz/wr18/8195663-fixHelpTest/webrev.02/
> which excludes the Oracle proprietary tools from the test.
> I can not verify this.

Wouldn't a whitelist work better here than a blacklist? Other 
distributions might add other tools (in theory).

David

> Best regards,
>    Goetz.
> 
> 
>> -----Original Message-----
>> From: jdk-dev [mailto:jdk-dev-bounces at openjdk.java.net] On Behalf Of
>> Lindenmaier, Goetz
>> Sent: Donnerstag, 18. Januar 2018 17:02
>> To: Weijun Wang <weijun.wang at oracle.com>
>> Cc: jdk-dev at openjdk.java.net
>> Subject: RE: RFR(XS): 8195663: jdk/tools/launcher/HelpFlagsTest.java fails
>> with java.lang.AssertionError: HelpFlagsTest failed:
>>
>> Hi,
>>
>> Added ssvagent:
>> http://cr.openjdk.java.net/~goetz/wr18/8195663-fixHelpTest/webrev.02/
>>
>> Best regards,
>>    Goetz.
>>
>>> -----Original Message-----
>>> From: Weijun Wang [mailto:weijun.wang at oracle.com]
>>> Sent: Donnerstag, 18. Januar 2018 16:44
>>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
>>> Cc: Kumar Srinivasan <kumar.x.srinivasan at oracle.com>; jdk-
>>> dev at openjdk.java.net
>>> Subject: Re: RFR(XS): 8195663: jdk/tools/launcher/HelpFlagsTest.java fails
>>> with java.lang.AssertionError: HelpFlagsTest failed:
>>>
>>> On Windows, there is also a ssvagent.exe.
>>>
>>>> On Jan 18, 2018, at 11:37 PM, Lindenmaier, Goetz
>>> <goetz.lindenmaier at sap.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> the most simple fix is to just exclude the four tools:
>>>> http://cr.openjdk.java.net/~goetz/wr18/8195663-
>> fixHelpTest/webrev.01/
>>>> Unfortunately I can't test this, as my build does not contain these
>>>> tools.
>>>>
>>>> If somebody tells me how to build these tools, I will adapt
>>>> the test to check them, and eventually adapt the tools to
>>>> CSR 8191477 https://bugs.openjdk.java.net/browse/JDK-8191477.
>>>>
>>>> What list should this be reviewed on? I just posted to jdk-dev for now.
>>>>
>>>> Best regards,
>>>>   Goetz.
>