[JDK 11] RFR 8196211: Move two sun/nio/cs tests into OpenJDK

Paul Sandoz paul.sandoz at oracle.com
Mon Jan 29 16:37:38 UTC 2018


That’s better :-)

If you wanna make it static i suggest:

  s/inputFileName/INPUT_FILE_NAME

although there is little benefit here since all access is local to main. Up to you to make local or keep static. No need for another review.

Paul.

> On Jan 29, 2018, at 4:17 AM, Amy Lu <amy.lu at oracle.com> wrote:
> 
> Updated on the inputFileName.
>  Please review: http://cr.openjdk.java.net/~amlu/8196211/webrev.01/ <http://cr.openjdk.java.net/~amlu/8196211/webrev.01/>
> 
> Thanks,
> Amy
> On 27/01/2018 2:32 AM, Paul Sandoz wrote:
>> Hi,
>> 
>> Quick observation.
>> 
>> EUCTWBufferBoundaryDecodeTest uses a different data file on windows and it uses the line separator as a trigger. Is it possible to better formalize this by passing in the argument for the file via jtreg?
>> 
>> Paul.
>> 
>> 
>>> On Jan 25, 2018, at 11:45 PM, Amy Lu <amy.lu at oracle.com> <mailto:amy.lu at oracle.com> wrote:
>>> 
>>> Please review the patch to move two sun/nio/cs tests into OpenJDK.
>>> 
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8196211 <https://bugs.openjdk.java.net/browse/JDK-8196211>
>>> webrev: http://cr.openjdk.java.net/~amlu/8196211/webrev.00/ <http://cr.openjdk.java.net/~amlu/8196211/webrev.00/>
>>> 
>>> Thanks,
>>> Amy
> 



More information about the core-libs-dev mailing list