hg: jdk/jdk11: 8202329: [AIX] Fix codepage mappings for IBM-943 and Big5

Bhaktavatsal R Maram bhamaram at in.ibm.com
Fri Jul 6 05:10:51 UTC 2018


Hi,

Sorry for the trouble. It had got compiled in my build environment, might be due to encoding is different. Please check if following patch make sense.


diff -r 5cb2d4a8b8d4 test/jdk/sun/nio/cs/TestIBMBugs.java
--- a/test/jdk/sun/nio/cs/TestIBMBugs.java      Tue Jun 12 13:00:50 2018 +0530
+++ b/test/jdk/sun/nio/cs/TestIBMBugs.java      Fri Jul 06 10:24:56 2018 +0530
@@ -174,7 +174,7 @@
     }
 
     private static void bug8202329() throws Exception {
-        String original = "\\\u007E\u00A5\u203E"; // "b"; \\ [backslash][tilde][yen][overscore]
+        String original = "\\\u007E\u00A5\u203E"; // [backslash][tilde][yen][overscore]
         byte[] expectedBytes; // bytes after conversion
         String expectedStringfromBytes; // String constructed from bytes
 
@@ -187,7 +187,7 @@
 
 
         // Test IBM943, where \ and ~ are encoded to unmappable i.e., 0x3f
-        // and ¥ andoverscore are encoded to 0x5c and 0x7e
+        // [yen] and [overscore] are encoded to 0x5c and 0x7e
         charset = Charset.forName("IBM943");
         expectedBytes = new byte[] {0x3f, 0x3f, 0x5c, 0x7e};
         expectedStringfromBytes = "??\u00A5\u203E";
@@ -204,7 +204,7 @@
 
 
         // Test IBM943C, where \ and ~ are encoded to 0x5c and 0x7e
-        // and ¥ an overscore are encoded to 0x5c and 0x7e
+        // [yen] and [overscore] are encoded to 0x5c and 0x7e
         charset = Charset.forName("IBM943C");
         expectedBytes = new byte[] {0x5c, 0x7e, 0x5c, 0x7e};
         expectedStringfromBytes = "\\~\\~";


Thanks,
Bhaktavatsal Reddy
  

-----"core-libs-dev" <core-libs-dev-bounces at openjdk.java.net> wrote: -----
To: volker.simonis at gmail.com
From: David Holmes 
Sent by: "core-libs-dev" 
Date: 07/06/2018 06:31AM
Cc: core-libs-dev Libs <core-libs-dev at openjdk.java.net>
Subject: Re: hg: jdk/jdk11: 8202329: [AIX] Fix codepage mappings for IBM-943 and Big5

Filed: https://bugs.openjdk.java.net/browse/JDK-8206436

David

On 6/07/2018 7:51 AM, David Holmes wrote:
> edit to TestIBMBugs.java contains non-ascii characters in the comments, 
> resulting in javac failure:
> 
> /scratch/opt/mach5/mesos/work_dir/jib-master/install/jdk11-jdk.1010/src.full/open/test/jdk/sun/nio/cs/TestIBMBugs.java:191: 
> error: unmappable character (0xC2) for encoding US-ASCII
>          // and \ufffd\ufffd andoverscore are encoded to 0x5c and 0x7e
>                 ^
> /scratch/opt/mach5/mesos/work_dir/jib-master/install/jdk11-jdk.1010/src.full/open/test/jdk/sun/nio/cs/TestIBMBugs.java:191: 
> error: unmappable character (0xA5) for encoding US-ASCII
>          // and \ufffd\ufffd andoverscore are encoded to 0x5c and 0x7e
>                  ^
> /scratch/opt/mach5/mesos/work_dir/jib-master/install/jdk11-jdk.1010/src.full/open/test/jdk/sun/nio/cs/TestIBMBugs.java:208: 
> error: unmappable character (0xC2) for encoding US-ASCII
>          // and \ufffd\ufffd an overscore are encoded to 0x5c and 0x7e
>                 ^
> /scratch/opt/mach5/mesos/work_dir/jib-master/install/jdk11-jdk.1010/src.full/open/test/jdk/sun/nio/cs/TestIBMBugs.java:208: 
> error: unmappable character (0xA5) for encoding US-ASCII
>          // and \ufffd\ufffd an overscore are encoded to 0x5c and 0x7e
>                  ^
> 4 errors
> result: Failed. Compilation failed: Compilation failed




More information about the core-libs-dev mailing list