RFR JDK-8206389: JarEntry.setCreation/LastAccessTime without setLastModifiedTime causes Invalid CEN header

[Martin Buchholz]

OK, looks good!

I would add something to check() to make sure that e.g. atime == null iff
ze.getLastAccessTime() == null

The zip time stuff is surprisingly messy.

On Fri, Jul 6, 2018 at 8:50 PM, Xueming Shen <xueming.shen at oracle.com>
wrote:

> On 7/6/18, 5:43 PM, Martin Buchholz wrote:
>
> I would use different timestamps for the 4 possible times used in this
> test, if only to make it clearer which value comes from where.
>
>
> webrev has been updated accordingly.
>
>
> +            // ze.setLastModifiedTime(now);+            ze.setTime(now.toMillis());
>
>
> setTime only sets the DOS time?  Which only has a granularity of 2
> seconds?  If so, how do you get back the same value you put in if the
> current second is odd?  Or am I misunderstanding the test?
>
>
> no misunderstanding, good catch. The test does fail when hits the odd
> second.
> added a special "check" version for the 2 second granularity set/getTime().
>
> Thanks,
> Sherman
>
>
>