[11] RFR: 8206445: JImageListTest.java failed in Windows
Alan Bateman
Alan.Bateman at oracle.com
Mon Jul 9 10:54:11 UTC 2018
On 09/07/2018 11:38, Srinivas Dama wrote:
> Hi,
>
> Please review
> webrev: http://cr.openjdk.java.net/~sdama/8206445/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8206445
>
testListEmptyFile looks okay but you can reduce the code if if you use
Path.of("."). testListNotAnImage can use Path.of(".") too. Also it can
use Files.writeString which will avoid the test trying to list the
contents of the image while the file is open.
Will you make sure to test this on all platforms before pushing? These
tests have been on and off the exclude list several times in the last
week and it would be good to check that this one is stable before it
runs again.
-Alan
More information about the core-libs-dev
mailing list