RFR(JDK12/JAXP/java.xml) 8194680: StartElement#getAttributes and getNamespaces refer to incorrect package

Lance Andersen lance.andersen at oracle.com
Wed Jul 11 17:49:22 UTC 2018


Hi Joe,

The updates like fine
> On Jul 10, 2018, at 11:10 PM, Joe Wang <huizhe.wang at oracle.com> wrote:
> 
> 
> 
> On 7/10/18, 4:39 PM, Jonathan Gibbons wrote:
>> 
>> 
>> 
>> On 7/10/18 4:27 PM, Joe Wang wrote:
>>> Hi,
>>> 
>>> Please review a javadoc fix for a couple of incorrect references to the javax.xml.stream package. Attribute and Namespace are both in the javax.xml.stream.events, and so is StartElement where they are referenced.
>>> 
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8194680
>>> webrevs: http://cr.openjdk.java.net/~joehw/jdk12/8194680/webrev/
>>> 
>>> Thanks,
>>> Joe
>> The following text does not read well:
>>   54    * Attributes are fundamentally unordered and may not be reported
>>   55    * in any order.
>> 
>> It would read better if it said:
>> 
>>   54    * Attributes are fundamentally unordered and may be reported
>>   55    * in any order.
>> 
>> (i.e. delete "not")
> 
> Done  (deleted "not").
> 
> Thanks,
> Joe
> 
>> 
>> -- Jon

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list