RFR 8189717: Too much documentation of ProcessBuilder.start copied to ProcessBuilder.startPipeline

Roger Riggs Roger.Riggs at Oracle.com
Tue Jul 17 14:09:33 UTC 2018


The corresponding CSR is:
   https://bugs.openjdk.java.net/browse/JDK-8207403

With a reviewer, it can be finalized sooner.

Thanks, Roger

On 7/13/2018 4:50 PM, Lance Andersen wrote:
> Hi Roger,
>
> +1
>
> Have a great weekend!
>
> Best
> Lance
>> On Jul 13, 2018, at 4:38 PM, Roger Riggs <Roger.Riggs at oracle.com 
>> <mailto:Roger.Riggs at oracle.com>> wrote:
>>
>> Hi Lance,
>>
>> Updated in place with your suggestion.
>> http://cr.openjdk.java.net/~rriggs/webrev-process-8189717/ 
>> <http://cr.openjdk.java.net/%7Erriggs/webrev-process-8189717/>
>>
>> Thanks, Roger
>>
>> On 7/13/2018 4:31 PM, Lance Andersen wrote:
>>> Hi Roger,
>>>
>>>> On Jul 13, 2018, at 3:48 PM, Roger Riggs <Roger.Riggs at Oracle.com 
>>>> <mailto:Roger.Riggs at Oracle.com>> wrote:
>>>>
>>>> Hi Lance,
>>>>
>>>> How about:
>>>> Subsequent modifications to any of {@code builder}swill not affect 
>>>> the returned {@link Process}.
>>> ….. to any of the specified builders ….
>>>
>>> At a minimum, you need  ‘the’ added to the above
>>>
>>>> Roger
>>>>
>>>>
>>>> On 7/13/2018 3:26 PM, Lance Andersen wrote:
>>>>> Hi Roger,
>>>>>
>>>>> I am struggling with the wording at:
>>>>>
>>>>> ———
>>>>> * Subsequent modifications to any of process builders in the 
>>>>> {@code builders}
>>>>> 1198 * argument will not affect the returned {@link Process}.
>>>>>
>>>>> ————
>>>>>
>>>>> Maybe specified/provided  process builders
>>>>>
>>>>> Not sure, will think about it a bit.
>>>>>
>>>>> Otherwise I think the changes are fine
>>>>>> On Jul 13, 2018, at 3:07 PM, Roger Riggs <Roger.Riggs at oracle.com 
>>>>>> <mailto:Roger.Riggs at oracle.com>> wrote:
>>>>>>
>>>>>> Please review a doc change to improve the description of 
>>>>>> ProcessBuilder.startPipeline.
>>>>>> The clarifications are not intended to imply any change in 
>>>>>> behavior and only focus the description
>>>>>> on the steps taken for each command in the pipeline.
>>>>>> (A CSR will be needed also when the wording is finalized).
>>>>>>
>>>>>> Webrev:
>>>>>> http://cr.openjdk.java.net/~rriggs/webrev-process-8189717/ 
>>>>>> <http://cr.openjdk.java.net/%7Erriggs/webrev-process-8189717/>
>>>>>> Issue:
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8189717
>>>>>>
>>>>>> Thanks, Roger
>>>>>>
>>>>>
>>>>> <oracle_sig_logo.gif> 
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
>>>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>> Oracle Java Engineering
>>>>> 1 Network Drive
>>>>> Burlington, MA 01803
>>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>
>>>
>>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>



More information about the core-libs-dev mailing list