8202794: Native Unix code should use readdir rather than readdir_r

Brian Burkhalter brian.burkhalter at oracle.com
Tue Jul 17 17:13:46 UTC 2018


On Jul 17, 2018, at 9:05 AM, B. Blaser <bsrbnd at gmail.com> wrote:

> On 17 July 2018 at 09:46, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>> 
>> For serviceability-dev but I assume OperatingSystemImpl.c should move to
>> readdir64 to be consistent with the other usages.

I made this small change:

http://cr.openjdk.java.net/~bpb/8202794/webrev.01/

>> Separately, we have few inconsistencies (including in TimeZone_md.c and
>> UnixFileSystem_md.c) where opendir/closedir is used instead of
>> opendir64/closedir64. Looks like the AIX port may have run into issues as it
>> redefines them. Something for a separate issue of course.

No changes made on these points.

> Looks good to me too.
> I've also noted the small inconsistencies between readdir64 and
> opendir/closedir to be addressed in a separate issue.

Is there any issue on file for these things? I could file one but perhaps someone else already knows more detail.

Thanks,

Brian


More information about the core-libs-dev mailing list