[12] RFR 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration

Chris Yin xu.y.yin at oracle.com
Mon Jul 30 00:59:15 UTC 2018


Thank you, Lance

Regards,
Chris

> On 27 Jul 2018, at 11:57 PM, Lance Andersen <lance.andersen at oracle.com> wrote:
> 
> Hi Chris,
> 
> This the change is fine
>> On Jul 27, 2018, at 4:42 AM, Chris Yin <xu.y.yin at oracle.com <mailto:xu.y.yin at oracle.com>> wrote:
>> 
>> Please review below minor change to add missing module dependencies declaration, thanks
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8208363 <https://bugs.openjdk.java.net/browse/JDK-8208363> <https://bugs.openjdk.java.net/browse/JDK-8208363 <https://bugs.openjdk.java.net/browse/JDK-8208363>>
>> 
>> Changes:
>> 
>> diff -r 65fc31d1042b test/jdk/java/lang/Package/PackageFromManifest.java
>> --- a/test/jdk/java/lang/Package/PackageFromManifest.java	Thu Jul 26 16:22:58 2018 -0700
>> +++ b/test/jdk/java/lang/Package/PackageFromManifest.java	Fri Jul 27 15:46:34 2018 +0800
>> @@ -29,6 +29,7 @@
>>  *          same package if multiple jars). Then verify package versioning info
>>  * @library /lib/testlibrary
>>  * @library /test/lib
>> + * @modules jdk.compiler
>>  * @run main PackageFromManifest setup test
>>  * @run main PackageFromManifest runJar test1.jar
>>  * @run main PackageFromManifest runJar test1.jar test2.jar foo.Foo1
>> 
>> 
>> Regards,
>> Chris
> 
> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
> 



More information about the core-libs-dev mailing list