[12] RFR 8208560: ChoiceFormat class has unused constants needs cleanup

Naoto Sato naoto.sato at oracle.com
Tue Jul 31 16:06:58 UTC 2018


+1

Naoto

On 7/31/18 7:57 AM, Roger Riggs wrote:
> Looks fine.
> 
> On 7/31/18 4:27 AM, Nishit Jain wrote:
>> Hi,
>>
>> Please review this cleanup fix for 8208560
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8208560
>> Webrev: http://cr.openjdk.java.net/~nishjain/8208560/webrev.00/
>>
>> Cause and Fix: Changes made for JDK-8021322 has left some unused 
>> static fields, not sure why these fields have package private access, 
>> but they are not getting used elsewhere in the package. Removed them 
>> from ChoiceFormat class.
>>
>> Regards,
>> Nishit Jain
> 


More information about the core-libs-dev mailing list