RFR JDK-8066709 Make some JDK system properties read only

[Lance Andersen]

Hi Roger,

Overall, it looks very good.

A couple of quick thoughts, nothing that needs any action unless you feel the desire :-)

Line 671 in System.java, it mentions ‘standard’ system properties.  (as does the existing Implementation note) but it does not really specify what a standard system property is (though it can be assumed) in getProperties overview.  Not a big deal, just thought I would point it out in case you had a alternative thought.

Do you think we should had a mention in getProperty() about this cached properties (or do we think the reference to getProperties() is enough)

Best
Lance
> On Jun 4, 2018, at 9:32 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> 
> Please review a change to make the values of java.home, user.home, user.dir, and user.name
> effectively read-only for internal use.  The values are cached during initialization and the
> cached values are used.
> 
> Webrev:
>   http://cr.openjdk.java.net/~rriggs/webrev-static-property-8066709/
> 
> Issue:
>   https://bugs.openjdk.java.net/browse/JDK-8066709
> 
> CSR:
>   https://bugs.openjdk.java.net/browse/JDK-8204235
> 
> Thanks, Roger
> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>