RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4
mandy chung
mandy.chung at oracle.com
Mon Jun 4 17:40:10 UTC 2018
Hi Jan,
On 5/31/18 2:11 AM, Jan Lahoda wrote:
> Hi,
>
> I'd like to upgrade the JOpt Simple library we are using to version 5.0.4.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8203891
> Complete webrev:
> http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/complete/
>
> Delta webrev only showing (all) JDK changes in JOpt Simple and related
> changes in tests needed for the upgrade, etc.:
> http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/joptsimple.delta/ >
> Probably the biggest issue with this upgrade is that for two subsequent
> parameters:
> "--libs=", "/tmp"
> "/tmp" used to be interpreted as the parameter of "libs", but now the
> "libs" parameter is empty (as there's nothing behind the '=').
This is a reasonable fix and no whitespace is expected following `=`.
> See the changes to test/jdk/tools/jmod/JmodTest.java for an example. Hopefully,
> this is a reasonable change.
114 "--libs=" + libDir.toString(),
Alternatively, you can take out `=` and run it as jmod --libs /tmp
"--libs", libDir.toString(),
Mandy
More information about the core-libs-dev
mailing list