RFR JDK-8066709 Make some JDK system properties read only
Brent Christian
brent.christian at oracle.com
Mon Jun 4 22:10:20 UTC 2018
Hi, Roger
A few things I noticed in src/java.base/share/classes/java/lang/System.java:
* Properties can also be set via setProperties(Properties p), though
that method is not mentioned in the doc changes (other than to
setProperties() itself).
750 * setting a standard property after initialization
's' -> 'S' in "setting"
788 * setting a standard property after initialization using
's' -> 'S' in "setting"
789 * {@link #getProperties()} or {@link #setProperty(String,
String)}
The doc change for getProperties() also mentions "clearProperty()", but
that one is not mentioned here.
The rest looks fine to me.
Thanks,
-Brent
On 6/4/18 6:32 AM, Roger Riggs wrote:
> Please review a change to make the values of java.home, user.home,
> user.dir, and user.name
> effectively read-only for internal use. The values are cached during
> initialization and the
> cached values are used.
>
> Webrev:
> http://cr.openjdk.java.net/~rriggs/webrev-static-property-8066709/
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8066709
>
> CSR:
> https://bugs.openjdk.java.net/browse/JDK-8204235
>
> Thanks, Roger
>
>
More information about the core-libs-dev
mailing list