RFR: 8201608 fix broken links in javax/sql/rowset/package.html and javax/sql/rowset/spi/package.html
Roger Riggs
roger.riggs at oracle.com
Wed Jun 6 15:26:51 UTC 2018
Hi Lance,
That's fine, the conversion from .html to .java made the diff extensive;
hiding the original link fix.
The changes are fine by me.
Roger
On 6/6/18 10:56 AM, Lance Andersen wrote:
> Hi Roger
>> On Jun 5, 2018, at 5:54 PM, Roger Riggs <roger.riggs at oracle.com
>> <mailto:roger.riggs at oracle.com>> wrote:
>>
>> Hi Lance,
>>
>> Can the name change be done using hg rename to preserve the continuity?
>
> I did do an hg rename, and just did it again in a different workspace:
>
> hg rename package.html package-info.java
> ljanders-mac:rowset ljanders$ hg status -mar
> M test/jdk/tools/jmod/hashes/HashesTest.java
> M test/jdk/tools/launcher/modules/addexports/AddExportsTest.java
> A src/java.sql.rowset/share/classes/javax/sql/rowset/package-info.java
> R src/java.sql.rowset/share/classes/javax/sql/rowset/package.html
>>
>> Also, while you are there, how about converting <code> to {@code...} etc.
>
> I do plan to do this, but thought I would keep things minimal for
> this updateand do that in a follow-on due to the renaming so it is
> easier to follow in the webrev.
>
>
> Best
> Lance
>>
>> Thanks, Roger
>>
>>
>> On 6/4/18 7:22 AM, Lance Andersen wrote:
>>> Hi,
>>>
>>> Bug 8201608 highlights a few broken links in
>>> javax/sql/rowset/package.html and javax/sql/rowset/spi/package.html
>>>
>>> As part of this fix, I took the liberty to move from package.html to
>>> package-info.java
>>>
>>> The webrev can be found at
>>> http://cr.openjdk.java.net/~lancea/8201608/webrev.00/
>>> <http://cr.openjdk.java.net/%7Elancea/8201608/webrev.00/>
>>> <http://cr.openjdk.java.net/~lancea/8201608/webrev.00/
>>> <http://cr.openjdk.java.net/%7Elancea/8201608/webrev.00/>>
>>>
>>> I have also attached a diff of the changes as it is less obvious of
>>> the webrev prior to the migration to package-info.java
>>>
>>> Best
>>> Lance
>>>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>> <mailto:Lance.Andersen at oracle.com>
>>>
>>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>
More information about the core-libs-dev
mailing list