RFR https://bugs.openjdk.java.net/browse/JDK-8204494

Roger Riggs roger.riggs at oracle.com
Wed Jun 6 21:13:57 UTC 2018


Hi Sherman,

Looks fine

Roger


On 6/6/18 3:39 PM, Xueming Shen wrote:
> Hi
>
> Please help review the change for JDK-8204494, a regression caused by 
> the fix for
> JDK-8200530 [1]. It appears that fix fails to deal with the corner 
> case that a pair of
> \r\n is at the boundary of the internal buf of 
> Manifest.FastInputtStream, which is
> 8192 for the default. In that scenario, the previous change fails to 
> consume the trailing
> \n, then triggers the Attributes parser fails to work on the 
> "continuation line" defined
> by the jar spec.
>
> issue: https://bugs.openjdk.java.net/browse/JDK-8204494
> webrev: http://cr.openjdk.java.net/~sherman/8204494/webrev/
>
> Fix has been verified by the regression reported in INTJDK-7627771.
>
> Thanks,
> Sherman
>
> [1] issue: https://bugs.openjdk.java.net/browse/JDK-8200530
>      webrev: http://cr.openjdk.java.net/~sherman/8200530/webrev
>



More information about the core-libs-dev mailing list