RFR: 8196990 :Resolve disabled warnings for libjli
Jim Laskey
james.laskey at oracle.com
Thu Jun 7 15:16:16 UTC 2018
+1
> On Jun 7, 2018, at 12:14 PM, Srinivas Dama <srinivas.dama at oracle.com> wrote:
>
> Ok. Thank you Jim.
> Please find revised webrev at http://cr.openjdk.java.net/~sdama/8196990/webrev.01/.
>
> Regards,
> Srinivas
>
> ----- Original Message -----
> From: james.laskey at oracle.com
> To: srinivas.dama at oracle.com, core-libs-dev at openjdk.java.net
> Sent: Thursday, 7 June, 2018 7:37:48 PM GMT +05:30 Chennai, Kolkata, Mumbai, New Delhi
> Subject: Re: RFR: 8196990 :Resolve disabled warnings for libjli
>
> traditionally there is a space after //
>
> simplify comment to something like (rest is redundant)
>
> // initialize to avoid -Werror=maybe-uninitialized issues from gcc 7.3 onwards.
>
>
>
>> On Jun 7, 2018, at 11:01 AM, Srinivas Dama <srinivas.dama at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review http://cr.openjdk.java.net/~sdama/8196990/webrev.00/
>> for https://bugs.openjdk.java.net/browse/JDK-8196990
>>
>> Regards,
>> Srinivas
>
More information about the core-libs-dev
mailing list