[RFR] 8204539: improve error messages in matchJavaTZ [windows]

[Baesken, Matthias]

Hi,  looks like I uploaded a wrong version of the patch.
Updated webrev is here  :

http://cr.openjdk.java.net/~mbaesken/webrevs/8204539.1/

I followed the advice of Sean and  removed  the  mapFileName   from the output because it is usually a static name .
Updated webrev was going through our internal build/tests .


Best regards, Matthias


From: Langer, Christoph
Sent: Donnerstag, 7. Juni 2018 13:52
To: Baesken, Matthias <matthias.baesken at sap.com>; core-libs-dev at openjdk.java.net
Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Subject: RE: [RFR] 8204539: improve error messages in matchJavaTZ [windows]

Hi Matthias,

in line 527, where the actual output is done, I think you would need to replace variable 'message' with 'outputMessage', otherwise I guess it won't compile??

Also, mapFileName can't be used at this place, because it has already been free'ed there.

But in general the additions make sense and will make it easier to find issues in the tzmappings file.

Best regards
Christoph

From: Baesken, Matthias
Sent: Donnerstag, 7. Juni 2018 13:35
To: core-libs-dev at openjdk.java.net<mailto:core-libs-dev at openjdk.java.net>
Cc: Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>
Subject: [RFR] 8204539: improve error messages in matchJavaTZ [windows]

Hi, could you please  review this small  change that improves  the error messages in  matchJavaTZ .
A reason of the failure is added to the message , and also  the offset where the error happened .


Bug :

https://bugs.openjdk.java.net/browse/JDK-8204539


Webrev :

http://cr.openjdk.java.net/~mbaesken/webrevs/8204539/


Thanks, Matthias