RFR 8204565 : (spec) Document java.{vm.}?specification.version system properties' relation to $FEATURE
mandy chung
mandy.chung at oracle.com
Fri Jun 8 19:27:57 UTC 2018
On 6/8/18 12:11 PM, Brent Christian wrote:
> On 6/7/18 1:24 PM, mandy chung wrote:
>>>
>>> Issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8204565
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~bchristi/8204565/webrev/
>>
>> Is there an existing test validating this?
>
> Looks like there is (kind of), for libs and for hotspot. I've rev'ed
> the webrev in place with how the tests might be updated. (or I can leave
> the hotspot test to be updated along with 8193719 if that's preferred).
test/jdk/java/lang/System/Versions.java
it can also verify java.vm.specification.version.
The hotspot test looks to me that it should expect the test be run
with OpenJDK build and the vendor verification should consider that.
That's a separate issue unrelated to this change. I suggest to
remove the comment at line 36.
Otherwise, looks good.
Mandy
More information about the core-libs-dev
mailing list