Review Request: 8204648: test/jdk/tools/launchers/SourceMode.java fails with long shebang line
mandy chung
mandy.chung at oracle.com
Sat Jun 9 04:29:53 UTC 2018
JDK-8204588 [1] fixed the test failure caused by long paths to the Java
launcher in some test execution environments, causing the shebang line
to overflow the underlying system limit of 128 characters.
The test needs a small tweak to the max javaCmd length to reduce from
100 to 90 since the arguments passed to java command are more than 28
characters. This is a quick fix for the test failure. A better fix
would be to compute the length of the entire shebang line in each test
case and determine if it should be skipped. That can be done as a
follow up fix.
diff --git a/test/jdk/tools/launcher/SourceMode.java
b/test/jdk/tools/launcher/SourceMode.java
--- a/test/jdk/tools/launcher/SourceMode.java
+++ b/test/jdk/tools/launcher/SourceMode.java
@@ -71,7 +71,7 @@
// limit of 120 characters for a shebang line.
Path p = cwd.relativize(cmd);
shortJavaCmd = (p.toString().length() <
cmd.toString().length()) ? p : cmd;
- skipShebangTest = shortJavaCmd.toString().length() > 100;
+ skipShebangTest = shortJavaCmd.toString().length() > 90;
}
log = System.err;
thanks
Mandy
[1]
http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-June/053700.html
More information about the core-libs-dev
mailing list