[core-libs] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

David Holmes david.holmes at oracle.com
Thu Jun 14 03:29:27 UTC 2018


On 13/06/2018 4:08 PM, joe darcy wrote:
> Hi David,
> 
> On 5/24/2018 10:52 PM, David Holmes wrote:
>> Here are the further minor updates so far in response to all the 
>> review comments.
>>
>> Incremental corelibs webrev:
>> http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.corelibs.v3-incr/ 
>>
>>
>> Full corelibs webrev:
>> http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.corelibs.v3/
>>
> 
> In Class.java,
> 
> 3990         Class<?>[] members = getNestMembers0();
> 3991         // Can't actually enable this due to bootstrapping issues
> 3992         // assert(members.length != 1 || members[0] == this); // 
> expected invariant from VM
> 
> can these checks be enabled unconditionally without using the assert 
> facility, throwing AssertionError or some other kind of error?

Of course - but we don't want to pay the price of always checking 
something that would indicate an error on the VM side. There's an 
equivalent assertion on the VM side.

Thanks,
David

> Thanks,
> 
> -Joe


More information about the core-libs-dev mailing list