RFR 7183985: Class.getAnnotation() throws an ArrayStoreException when the annotation class not present
Liam Miller-Cushon
cushon at google.com
Fri Jun 15 17:21:17 UTC 2018
Thanks, I pushed it as: http://hg.openjdk.java.net/jdk/jdk/rev/9f4c08c444e8
On Thu, Jun 14, 2018 at 10:31 AM Vicente Romero <vicente.romero at oracle.com>
wrote:
> I'm not an expert in the area, but the patch looks good to me,
>
> Vicente
>
> On 05/31/2018 08:39 PM, Liam Miller-Cushon wrote:
> > Hi,
> >
> > Are there any concerns with the patch that I can address? I was hoping to
> > get this in to JDK 11.
> >
> > I confirmed that it still builds and passes all tests at head.
> >
> > Thanks,
> > Liam
> >
> > On Mon, May 14, 2018 at 10:38 AM Liam Miller-Cushon <cushon at google.com>
> > wrote:
> >
> >> Ping
> >>
> >> On Thu, Apr 5, 2018 at 10:57 AM Liam Miller-Cushon <cushon at google.com>
> >> wrote:
> >>
> >>> Hi,
> >>>
> >>> Is there any more feedback on the patch?
> >>>
> >>> On Wed, Feb 28, 2018 at 4:26 PM Liam Miller-Cushon <cushon at google.com>
> >>> wrote:
> >>>
> >>>> On Wed, Feb 28, 2018 at 4:13 PM, Martin Buchholz <martinrb at google.com
> >
> >>>> wrote:
> >>>>
> >>>>> Follow their lead and rename your method to assertArrayEquals
> >>>>>
> >>>> Done: http://cr.openjdk.java.net/~cushon/7183985/webrev.04/
> >>>>
>
>
More information about the core-libs-dev
mailing list