RFR 8204310 : Simpler RandomAccessFile.setLength() on Windows
Alan Bateman
Alan.Bateman at oracle.com
Wed Jun 20 12:27:27 UTC 2018
On 11/06/2018 07:15, Ivan Gerasimov wrote:
> :
> I extended the existing reg. test
> java/io/RandomAccessFile/SetLength.java to cover more cases that
> involve changing the file size.
>
> Also I added another regression test, as you Alan suggested, to check
> that RandomAccessFile and its FileChannel behave consistently in
> various scenarios.
>
> All the tests, including the new ones, pass on all supported platforms.
>
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8204310
> WEBREV: http://cr.openjdk.java.net/~igerasim/8204310/01/webrev/
>
> Would you please help review the fix?
>
The expanded test coverage looks good and really important when touching
this Windows specific code (as you know, although every change in this
area results in some behavioral change that shows up months or years
after the fact). So I think this is good to go although it may be more
prudent to wait until after JDK 11 is forked next week.
-Alan
More information about the core-libs-dev
mailing list