RFR [XS] : 8205416 : windows: fix checking of CloseHandle return code in Java_java_io_FileCleanable_cleanupClose0

[Thomas Stüfe]

On Wed, Jun 20, 2018 at 2:30 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>
>
> On 20/06/2018 13:16, Thomas Stüfe wrote:
>>
>> :
>>
>> I am curious whether we now get a bunch of follow up errors, since
>> before we never catched a failing CloseHandle. A typical reason why
>> this could fail would be a double close.
>>
> Yes, and it typically means that something is seriously broken. We had
> exactly this early in JDK 11 where some refactoring (to make use of Cleaner)
> introduced a bug that lead to random closing of sockets. So important that
> any failures like this are diagnosed quickly.
> -Alan

Even more fun if the double close actually succeeds because of handle reuse :-)

Unix is good though, so whatever error we unearth will be windows specific.

..Thomas