<i18n dev> RFR JDK-8204938: Add a test case to automatically check the updated LSR data
Roger Riggs
Roger.Riggs at Oracle.com
Wed Jun 20 18:53:40 UTC 2018
Hi Nishit,
Looks ok
My only comment would be to put the relative path to the
language-subtag-registry.txt in a private static final constant
to call attention to the dependency on the source layout instead of
burying it in the code.
$.02, Roger
On 6/20/2018 2:27 PM, naoto.sato at oracle.com wrote:
> Looks good.
>
> Naoto
>
> On 6/20/18 3:32 AM, Nishit Jain wrote:
>> Hi,
>>
>> Please review the fix for JDK-8204938
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8204938
>> Webrev: http://cr.openjdk.java.net/~nishjain/8204938/webrev.02/
>>
>> Fix: Added a test case to cross check the LSR data generated for the
>> JDK APIs. So, for each lsr data update, the test case need not be
>> updated, it automatically cross checks the updated lsr data.
>>
>> Regards,
>> Nishit Jain
More information about the core-libs-dev
mailing list