RFR 8202292 : test/jdk/java/io/FileOutputStream/UnreferencedFOSClosesFd.java fails with "raw fd count wrong"
Roger Riggs
Roger.Riggs at Oracle.com
Mon Jun 25 13:33:05 UTC 2018
Created new issue: https://bugs.openjdk.java.net/browse/JDK-8205610
Thanks for the suggestion David
On 6/25/2018 1:00 AM, David Holmes wrote:
> Hi Roger,
>
> On 23/06/2018 12:49 AM, Roger Riggs wrote:
>> Hi Brian, Mandy,
>>
>> Listing the open file descriptors can be a useful utility. Originally
>> I thought it was a temporary and throw away code.
>> To be a utility it needed to be a bit more general (sending the
>> output to a particular stream).
>> Thanks for the suggestions.
>
> You might want to look at the code Leo used for a hotspot test
> recently. It covers more locations for lsof and also supports pfiles
> for Solaris:
>
> http://hg.openjdk.java.net/jdk/jdk/rev/9ba6f5dfbe56
> http://hg.openjdk.java.net/jdk/jdk/rev/1372f66e0a17
>
> But there can be other locations like /usr/local/bin for lsof on
> Solaris too.
>
> David
>
>> Please review:
>> http://cr.openjdk.java.net/~rriggs/webrev-count-wrong-8202292/
>>
>> Thanks, Roger
>>
>> On 6/21/2018 3:25 PM, Brian Burkhalter wrote:
>>> Hi Roger,
>>>
>>> Are the three versions of listProcFD() identical? Is so, could this
>>> method be put in test/lib/jdk/test/lib/util/FileUtils.java instead?
>>>
>>> Thanks,
>>>
>>> Brian
>>>
>>> On Jun 21, 2018, at 11:59 AM, Roger Riggs <Roger.Riggs at Oracle.com
>>> <mailto:Roger.Riggs at Oracle.com>> wrote:
>>>
>>>> Please review a test improvement to avoid spurious errors caused by
>>>> concurrent changes in open files during the test.
>>>> The other existing conditions in the test are sufficient to verify
>>>> the correct finalize behavior.
>>>> Some additional diagnostics are added and the tests removed from
>>>> the problem list.
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~rriggs/webrev-count-wrong-8202292/index.html
>>>> <http://cr.openjdk.java.net/%7Erriggs/webrev-count-wrong-8202292/index.html>
>>>>
>>>>
>>>> Issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-8202292
>>>
>>
More information about the core-libs-dev
mailing list