RFR: JDK-8197594: String#repeat

[Paul Sandoz]

Hi Jim,

Looks good. I like the power of 2 copying.


2978      * @throws  IllegalArgumentException if the {@code count} is
2979      *          negative.
2980      */
2981     public String repeat(int count) {

Missing @since11 on the method.


Like Stuart suggests, turn the explanatory text into an api note, perhaps with a small code sample.

Thanks,
Paul.
 

> On Feb 28, 2018, at 8:31 AM, Jim Laskey <james.laskey at oracle.com> wrote:
> 
> Introduction of a new instance method String::repeat to allow an efficient and concise approach for generating repeated character sequences as strings.
> 
> Performance information in JBS.
> 
> Thank you.
> 
> Cheers,
> 
> — Jim
> 
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8197594 <https://bugs.openjdk.java.net/browse/JDK-8197594>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8198296
> <http://cr.openjdk.java.net/~jlaskey/8197594/String.html>
> Webrev: http://cr.openjdk.java.net/~jlaskey/8197594/webrev-02/index.html <http://cr.openjdk.java.net/~jlaskey/8197594/webrev-02/index.html>
> JavaDoc: http://cr.openjdk.java.net/~jlaskey/8197594/String.html <http://cr.openjdk.java.net/~jlaskey/8197594/String.html>
> 
> 
>