[PATCH] 8188240: Reflection Proxy should skip static methods

mandy chung mandy.chung at oracle.com
Wed Mar 14 18:44:52 UTC 2018



On 3/14/18 11:37 AM, Aleksey Shipilev wrote:
> On 03/14/2018 07:09 PM, David Lloyd wrote:
>> On Wed, Mar 14, 2018 at 1:00 PM, mandy chung <mandy.chung at oracle.com> wrote:
>>> Thanks for adding the new test.   Looks okay and some minor comment.
>>>
>>> +        try {
>>>     :
>>> +        } catch (Throwable e) {
>>> +            System.err.println("\nTEST FAILED:");
>>> +            e.printStackTrace();
>>> +            throw new RuntimeException("TEST FAILED: " + e.toString());
>>> +        }
>>>
>>>
>>> You can take out this try-catch (Basic1.java isn't be the best example to
>>> reference that is old and needs update).
>> Fixed & attached.
>>
>>> I assume your colleague at Red Hat will sponsor it for you?
>> I will find out.
> I can do it, but I need to get updated on two things:
>   a) Are we pushing JDK changes directly to jdk/jdk now?
>   b) Do we need to run it through JDK Submit first, or that is optional for this change?

While this patch is trivial, I recommend to run through JDK submit since 
proxies are used by other areas.  I did find surprises in the past via 
testing on trivial proxy class changes.

Mandy



More information about the core-libs-dev mailing list