[PATCH] 8188240: Reflection Proxy should skip static methods

[Andrej Golovnin]

Hi David,

+                if (! Modifier.isStatic(m.getModifiers())) {

I think the whitespace after the ‘!’-sign should be removed.

Best regards,
Andrej Golovnin

> On 14. Mar 2018, at 19:09, David Lloyd <david.lloyd at redhat.com> wrote:
> 
> On Wed, Mar 14, 2018 at 1:00 PM, mandy chung <mandy.chung at oracle.com> wrote:
>> Thanks for adding the new test.   Looks okay and some minor comment.
>> 
>> +        try {
>>   :
>> +        } catch (Throwable e) {
>> +            System.err.println("\nTEST FAILED:");
>> +            e.printStackTrace();
>> +            throw new RuntimeException("TEST FAILED: " + e.toString());
>> +        }
>> 
>> 
>> You can take out this try-catch (Basic1.java isn't be the best example to
>> reference that is old and needs update).
> 
> Fixed & attached.
> 
>> I assume your colleague at Red Hat will sponsor it for you?
> 
> I will find out.
> 
> -- 
> - DML
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch-8188240.txt
URL: <http://mail.openjdk.java.net/pipermail/core-libs-dev/attachments/20180314/461555bb/patch-8188240.txt>
-------------- next part --------------
>