RFR 8196298 Add null Reader and Writer with latest changes

[Roger Riggs]

Hi Patrick,

Looks good,

If there are no more comments, I can sponsor the commit.

Thanks, Roger


On 3/16/18 2:10 AM, Patrick Reinhart wrote:
> Just coming back on my webrev [1]. Are there any more feedbacks implementation wise to that latest version? If no I would need a commit sponsor for this change as the CSR [2] is reviewed and closed.
>
> -Patrick
>
> [1] http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.02
> [2] https://bugs.openjdk.java.net/browse/JDK-8196350
>
>
>> Am 07.03.2018 um 11:41 schrieb Patrick Reinhart <patrick at reini.net>:
>>
>> I applied those changes here:
>>
>> http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.02
>>
>> -Patrick
>>
>>
>>> Am 06.03.2018 um 23:12 schrieb Brian Burkhalter <brian.burkhalter at oracle.com>:
>>>
>>> Yes, I think so and and also the parameter ‘csq' is allowed to be null so Objects.requireNonNull(csq) should be removed at lines 100 and 107 as no NPE is specified for these methods [1, 2].
>>>
>>> Thanks,
>>>
>>> Brian
>>>
>>> [1] https://download.java.net/java/jdk10/docs/api/java/io/Writer.html#append(java.lang.CharSequence)
>>> [2] https://download.java.net/java/jdk10/docs/api/java/io/Writer.html#append(java.lang.CharSequence,int,int)
>>>
>>> On Mar 6, 2018, at 11:49 AM, Bernd Eckenfels <ecki at zusammenkunft.net> wrote:
>>>
>>>> Just a nit, Should append(CharSequence,int,int) also use checkFromIndexSize?