RFR: 8200238: Reduce number of exceptions created when calling MemberName$Factory::resolveOrNull

David Holmes david.holmes at oracle.com
Tue Mar 27 07:03:44 UTC 2018


Hi Claes,

This seems reasonable. Clearing the exception only when speculatively 
resolving is reasonable (it's similar to compilation clearing exceptions 
and falling back to interpreted mode).

Thanks,
David

On 27/03/2018 4:49 PM, Claes Redestad wrote:
> 
> 
> On 2018-03-26 17:51, Claes Redestad wrote:
>> Karen,
>>
>> On 2018-03-26 17:15, Karen Kinnear wrote:
>>> Claes,
>>>
>>> Discussed with Lois. We think that it would make more sense to pass 
>>> the new argument into MethodHandles::resolve_MemberName and at all 
>>> three places that we currently CHECK_PENDING_EXCEPTION/return null there
>>>     - if speculative flag is set - CLEAR_PENDING_EXCEPTION before you 
>>> return null
>>>     - and yes - do this for all three cases, not just the METHOD case
>>
>> ok.
> 
> New webrev:
> 
> http://cr.openjdk.java.net/~redestad/8200238/open.01/
> 
> Thanks!
> 
> /Claes


More information about the core-libs-dev mailing list