RFR: Some patches for sherman

Xueming Shen xueming.shen at oracle.com
Tue Mar 27 16:24:24 UTC 2018


looks good for me.

On 3/26/18, 5:21 PM, Martin Buchholz wrote:
>
> 8200116: ConstructInflaterOutput, ConstructDeflaterInput still 
> spamming test logs
> http://cr.openjdk.java.net/~martin/webrevs/jdk/ConstructInflaterOutput/ <http://cr.openjdk.java.net/%7Emartin/webrevs/jdk/ConstructInflaterOutput/>
> https://bugs.openjdk.java.net/browse/JDK-8200116
>
> 8200124: Various cleanups in jar/zip
> http://cr.openjdk.java.net/~martin/webrevs/jdk/zip-cleanup/ 
> <http://cr.openjdk.java.net/%7Emartin/webrevs/jdk/zip-cleanup/>
> https://bugs.openjdk.java.net/browse/JDK-8200124

don't see any change in ZipCoder.java though.


>
> This one I'm not too sure about:
> The public fields of StandardCharsets are part of the public API, so 
> they definitely need to exist.  So let's create them directly (i.e. 
> using "new", not Charset.forName) and don't bother putting these 
> fields anywhere else.
>
> Motivation: I ran into trouble using reflection via 
> StandardCharsets.<clinit> too early during bootstrap with a local mod.
>
> 00000000: Avoid charset lookup machinery in StandardCharsets
> http://cr.openjdk.java.net/~martin/webrevs/jdk/StandardCharsets/ 
> <http://cr.openjdk.java.net/%7Emartin/webrevs/jdk/StandardCharsets/>
>



More information about the core-libs-dev mailing list