[11] RFR: 8191410 : Unicode 10.0.0

[Ivan Gerasimov]

Thanks Rachna!


On 3/13/18 2:28 AM, Rachna Goel wrote:
>
> Hi Roger, Ivan,
>
> There is no change in algorithm as such but there has been mainly 
> stability improvements, defects fixed, performance enhancements. e.g 
> Updated header check, version and loading for latest binary files, 
> Simple case mappings will be more efficient as unnecessary checking 
> has been removed.
> complete list of changes can be found at:
>
> http://bugs.icu-project.org/trac/query?status=closed&resolution=fixed&resolution=fixedbyotherticket&milestone=60.1&milestone=60.2&group=project&max=999&col=id&col=summary&col=resolution&col=milestone&col=status&col=owner&col=type&col=priority&col=project&col=weeks&order=priority
>
> Also, I have incorporated  suggestions given from Ivan.
> Kindly have a look at updated webrev:
>
> http://cr.openjdk.java.net/~rgoel/JDK-8191410/webrev.01/
>

Please update the comment at the line 675 in Character.java:
* 638  - the expected number of entities

Please also update the test 
test/jdk/java/lang/Character/UnicodeBlock/OptimalMapSize.java:
the expected capacity 510 needs to be replaced with 638

With kind regards,
Ivan

> Thanks,
> Rachna
>
>
> On 3/8/18 9:47 PM, Roger Riggs wrote:
>> Hi Rachna,
>>
>> sun/text/normalizer/NormalizerImpl.java:
>>
>> Is there a higher level description of the algorithmic changes?
>>
>> 102-105:   These look like accidental changes: the space should not 
>> be removed and the trailing "{" doesn't make sense in a comment.
>>
>> Regards, Roger
>>
>>
>> On 3/8/2018 6:56 AM, Rachna Goel wrote:
>>> Hi,
>>>
>>> Please review the proposed changes for JDK-819410.
>>>
>>> Bug : https://bugs.openjdk.java.net/browse/JDK-8191410
>>>
>>> proposed changeset is located at :
>>>
>>> http://cr.openjdk.java.net/~rgoel/JDK-8191410/webrev/
>>>
>>> This serves as the implementation for JEP 327.
>>>
>>
>
> -- 
> Thanks,
> Rachna

-- 
With kind regards,
Ivan Gerasimov