RFR: 8195649: reorganize tests for java.util.Optional

Paul Sandoz paul.sandoz at oracle.com
Fri Mar 30 17:35:09 UTC 2018


Very nice +1.

You can probably remove the "groups = “unit”" from the @Test declarations.

Paul.


> On Mar 29, 2018, at 6:12 PM, Stuart Marks <stuart.marks at oracle.com> wrote:
> 
> Hi all,
> 
> Please review this changeset, which reorganizes (basically rewrites) the tests for Optional and Optional{Double,Int,Long}. The new arrangement clusters all the assertions together into check* methods. These are then called on the results of the various factories and other monadic operations. This reduced the amount of test code and actually increased the test coverage slightly.
> 
> Bug:
> 
> 	https://bugs.openjdk.java.net/browse/JDK-8195649
> 
> Webrev:
> 
> 	http://cr.openjdk.java.net/~smarks/reviews/8195649/webrev.0/
> 
> Thanks,
> 
> s'marks



More information about the core-libs-dev mailing list