RFR(M): 8202745: Remove hyphens from "out-of-bounds".
David Holmes
david.holmes at oracle.com
Mon May 7 21:43:19 UTC 2018
Hi Goetz,
The grammar can be a bit subtle here. IIUC we would say:
"Index %d out of bounds for length %d"
but if we turn it around we'd say:
"out-of-bounds index %d for length %d"
Anyway changes seem fine to me. Couple of comments below.
On 8/05/2018 7:26 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> as a follow up to "8201593: Print array length in ArrayIndexOutOfBoundsException." I promised
> to check all occurances of out-of-bounds.
> This change fixes them wherever the term is not used as an adjective:
> http://cr.openjdk.java.net/~goetz/wr18/8202745-out-of-bounds/01/
> Please review.
src/hotspot/cpu/ppc/ppc.ad
I'd consider that an adjective form. It should say "// Throw
out-of-bounds exception if ..."
src/java.base/share/classes/java/util/Objects.java
I'll just note that this grammatical change does not require a CSR request.
Thanks,
David
> Best regards,
> Goetz.
>
>
More information about the core-libs-dev
mailing list