[11] RFR: 8170769 Provide a simple hexdump facility for binary data

[Vincent Ryan]

> On 10 May 2018, at 01:08, Weijun Wang <weijun.wang at oracle.com> wrote:
> 
> 
> 
>> On May 10, 2018, at 6:49 AM, Vincent Ryan <vincent.x.ryan at oracle.com> wrote:
>> 
>>> 
>>> - As Max observes, being able to supply the delimiters might be a good addition.  (I'm thinking IP addresses too).
>> 
>> Sure. Add another toHexString method that takes a delimiter character?
> 
> Good idea.
> 
> Still, I am not sure about all those methods taking InputStream as an input. Most likely I would use this class for debugging purpose, so any side effect (advancing inside an InputStream or ByteBuffer) might not be desirable. 
> 
> Another question, I just noticed that sun.security.HexDumpEncoder emits uppercase letters (ABCDEF) and your code emits lowercase letters. Do we need to provide user a choice here?

The hexdump format uses lowercase but it is trivial to generate uppercase using a custom formatter.


> 
> Thanks
> Max
>