RFR (S): 8202915: [JAXP] Performance enhancements and cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator

Langer, Christoph christoph.langer at sap.com
Thu May 10 16:01:44 UTC 2018


One addition: I think it would be more appropriate to completely remove the commented lines but I didn't dare to do so yet. What do you think?
From: Langer, Christoph
Sent: Donnerstag, 10. Mai 2018 17:51
To: core-libs-dev at openjdk.java.net; 'Joe Wang' <huizhe.wang at oracle.com>
Subject: RFR (S): 8202915: [JAXP] Performance enhancements and cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator

Hi,

here is a little contribution that has been in SAP's JVM for several. In method XMLDTDValidator::getAttributeTypeName(XMLAttributeDecl attrDecl), a StringBuilder, preallocated to the expected length vs. a default StringBuffer could help performance for "XMLSimpleType.TYPE_ENUMERATION". I also took the chance to do some further cleanups in that class (removing/uncommenting unused variables and code lines).

Please help reiviewing.

Bug: https://bugs.openjdk.java.net/browse/JDK-8202915
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8202915.0/

Thank you
Christoph



More information about the core-libs-dev mailing list