RFR (S): 8202915: [JAXP] Performance enhancements and cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator

[Joe Wang]

Hi Christoph,

Thanks for doing this!  Yes, I'm fine with the additional cleanup as 
well. They were so obsolete, like 20 years :-), plus the old bug system 
was long gone.

Yes, running test jaxp_all would be good.

Best regards,
Joe

On 5/10/2018 2:08 PM, Langer, Christoph wrote:
>
> Hi Joe,
>
> thanks for reviewing.
>
> Then this would be my proposal with removing the obsolete stuff: 
> http://cr.openjdk.java.net/~clanger/webrevs/8202915.1/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8202915.1/>
>
> I also removed some code that was already commented out (with some BUG 
> tags…)
>
> Are you fine with that?
>
> I’ll run it through the jtreg suite before pushing, of course.
>
> Best regards
>
> Christoph
>
> *From:*Joe Wang [mailto:huizhe.wang at oracle.com]
> *Sent:* Donnerstag, 10. Mai 2018 20:08
> *To:* Langer, Christoph <christoph.langer at sap.com>; 
> core-libs-dev at openjdk.java.net
> *Subject:* Re: RFR (S): 8202915: [JAXP] Performance enhancements and 
> cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator
>
> Thanks for bringing in what's been in SAP's JVM. The change looks good 
> to me. On whether to remove the commented lines (the unused 
> getContentSpecType method), I would say yes since that was replaced 
> with that of a DTDGrammar method a long long time ago :-)
>
> Cheers,
> Joe
>
> On 5/10/2018 9:01 AM, Langer, Christoph wrote:
>
>     One addition: I think it would be more appropriate to completely
>     remove the commented lines but I didn’t dare to do so yet. What do
>     you think?
>
>     *From:*Langer, Christoph
>     *Sent:* Donnerstag, 10. Mai 2018 17:51
>     *To:* core-libs-dev at openjdk.java.net
>     <mailto:core-libs-dev at openjdk.java.net>; 'Joe Wang'
>     <huizhe.wang at oracle.com> <mailto:huizhe.wang at oracle.com>
>     *Subject:* RFR (S): 8202915: [JAXP] Performance enhancements and
>     cleanups in
>     com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator
>
>     Hi,
>
>     here is a little contribution that has been in SAP’s JVM for
>     several. In method
>     XMLDTDValidator::getAttributeTypeName(XMLAttributeDecl attrDecl),
>     a StringBuilder, preallocated to the expected length vs. a default
>     StringBuffer could help performance for
>     “XMLSimpleType.TYPE_ENUMERATION”. I also took the chance to do
>     some further cleanups in that class (removing/uncommenting unused
>     variables and code lines).
>
>     Please help reiviewing.
>
>     Bug: https://bugs.openjdk.java.net/browse/JDK-8202915
>     <https://bugs.openjdk.java.net/browse/JDK-8202915>
>
>     Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8202915.0/
>     <http://cr.openjdk.java.net/%7Eclanger/webrevs/8202915.0/>
>
>     Thank you
>
>     Christoph
>