RFR: 8196340: (coll) Examine overriding inherited methods in ArrayList and ArrayList.SubList
Martin Buchholz
martinrb at google.com
Fri May 11 17:02:38 UTC 2018
Thanks Claes,
This all looks correct, but I would ....
- rename the ranged version of lastIndexOf lastIndexOfRange
- introduce hashCodeRange and equalsRange
- add "final" to all the Object[] es
- hesitate to optimize ArrayList.equals(ArrayList). Do you have a
particular use case in mind?
At some point we will want to make all the package-private methods truly
private due to Nestmates, but I'm hoping someone will use tool support to
do that in bulk.
On Fri, May 11, 2018 at 6:55 AM, Claes Redestad <claes.redestad at oracle.com>
wrote:
> Hi,
>
> ArrayList doesn't override AbstracList#equals, and ArrayList$SubList
> doesn't override indexOf and equals. This provides specialized and more
> efficient implementations.
>
> Webrev: http://cr.openjdk.java.net/~redestad/8196340/open.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8196340
>
> Testing: passed all jdk-tier1 tests
>
> /Claes
>
More information about the core-libs-dev
mailing list