RFR: JDK-8200380 String::lines

Roger Riggs roger.riggs at oracle.com
Fri May 18 14:39:15 UTC 2018


Hi Jim,

Can you add some test cases for the UTF-16.  I think all the cases fall 
into the Latin1 encoding.
The rest looks fine.

Roger

On 5/18/18 10:31 AM, Sundararajan Athijegannathan wrote:
> +1
>
> I think LinesSpliterator classes in StringLatin1 and StringUTF8 could 
> be "private" and "final".
>
> -Sundar
>
> On 18/05/18, 7:14 PM, Jim Laskey wrote:
>> String::lines instance method that returns a Stream<String>  with 
>> elements composed of substrings from the original string delimited by 
>> any recognized new line character sequence.
>>
>> webrev: 
>> http://cr.openjdk.java.net/~jlaskey/8200380/webrev/index.html<http://cr.openjdk.java.net/~jlaskey/8200380/webrev/index.html>
>> bug: 
>> https://bugs.openjdk.java.net/browse/JDK-8200380<https://bugs.openjdk.java.net/browse/JDK-8200380>
>> csr: 
>> https://bugs.openjdk.java.net/browse/JDK-8200425<https://bugs.openjdk.java.net/browse/JDK-8200425>
>>
>>



More information about the core-libs-dev mailing list